Use gvk in multicluster client to map resources#495
Merged
PhilippMatthes merged 8 commits intomainfrom Feb 5, 2026
Merged
Conversation
PhilippMatthes
requested review from
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
PaulPickhardt
approved these changes
Feb 5, 2026
SoWieMarkus
reviewed
Feb 5, 2026
SoWieMarkus
reviewed
Feb 5, 2026
Co-authored-by: Markus Wieland <44964229+SoWieMarkus@users.noreply.github.com>
Co-authored-by: Markus Wieland <44964229+SoWieMarkus@users.noreply.github.com>
Co-authored-by: Markus Wieland <44964229+SoWieMarkus@users.noreply.github.com>
Contributor
Test Coverage ReportTest Coverage 📊: 68.3% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, it was necessary for resources to declare a
URI()method to be registered in the multicluster client. Now, this is handled over the group version kind (gvk), allowing us to also handle resources outside of our own packages with the multicluster client, such as the hypervisor crd. This makes use of the fact that each type handled by the controller-runtime client conforms to the runtime.Object interface, providing the gvk overGetObjectKind.